Don't try to set TCP_NODELAY on Unix socket #4343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dblsaiko
force-pushed
the
push-ttmspnpsmzzt
branch
from
4d8a9f1 to
a27d417
Compare
dblsaiko
force-pushed
the
push-ttmspnpsmzzt
branch
from
a27d417 to
5f43db0
Compare
sandhose
approved these changes
Apr 6, 2025
|
@2xsaiko Thanks for this! I need you to sign the CLA for me to merge this PR, but other than that, looks good to me! |
Signed-off-by: Katalin Rebhan <[email protected]>
auto-merge was automatically disabled
May 13, 2025 16:53
Head branch was pushed to by a user without write access
dblsaiko
force-pushed
the
push-ttmspnpsmzzt
branch
from
5f43db0 to
b14fb35
Compare
|
This was done in #4829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP_NODELAY is not applicable on Unix sockets, so trying to accept a connection on the socket always fails here (
Os { code: 95, kind: Uncategorized, message: "Operation not supported" }).Closes #4335.